Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken link : #260

Merged
merged 1 commit into from
Apr 8, 2020
Merged

fix broken link : #260

merged 1 commit into from
Apr 8, 2020

Conversation

CriaHu
Copy link
Contributor

@CriaHu CriaHu commented Apr 6, 2020

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @CriaHu!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2020
@damemi
Copy link
Contributor

damemi commented Apr 6, 2020

/close
this looks good to me but I'm going to try re-opening it to see if travis can get unstuck

@k8s-ci-robot
Copy link
Contributor

@damemi: Closed this PR.

In response to this:

/close
this looks good to me but I'm going to try re-opening it to see if travis can get unstuck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi
Copy link
Contributor

damemi commented Apr 6, 2020

/reopen

@k8s-ci-robot
Copy link
Contributor

@damemi: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Apr 6, 2020
damemi
damemi approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2020
@seanmalloy
Copy link
Member

/lgtm
/assign @aveshagarwal @ravisantoshgudimetla

ravisantoshgudimetla
ravisantoshgudimetla approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @CriaHu

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CriaHu, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ravisantoshgudimetla]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit e3a562a into kubernetes-sigs:master Apr 8, 2020
@seanmalloy seanmalloy mentioned this pull request Apr 9, 2020
Closed
@seanmalloy seanmalloy mentioned this pull request May 20, 2020
Closed
4 tasks
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#260 from CriaHu/hyq_descheduler
294d512 
fix broken link :
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@damemi damemi damemi approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@seanmalloy seanmalloy

@damemi damemi

@aveshagarwal aveshagarwal

@ravisantoshgudimetla ravisantoshgudimetla

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CriaHu @k8s-ci-robot @damemi @seanmalloy @ravisantoshgudimetla @aveshagarwal